Repository navigation
Merged
Conversation
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Member
|
Converting to "draft" to prevent accidental merging, since the 3.0.1 will happen when we get the OMG feedback and incorporate whatever changes come up. |
zvr
marked this pull request as draft
October 17, 2024 19:31
kestewart
approved these changes
Nov 14, 2024
bact
marked this pull request as ready for review
November 14, 2024 19:23
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Collaborator
Author
|
(Mark as draft again to prevent merge until we decide to freeze. Was undrafted previously to merge changes from main.) |
bact
marked this pull request as draft
November 15, 2024 14:44
Contributor
|
@bact - when will you feel comfortable moving this out of draft? I think we're getting ready to tag 3.0.1; and it would be good for this to be part of it. |
bact
marked this pull request as ready for review
November 15, 2024 16:29
Collaborator
Author
|
@kestewart I think it's ready. Just recently logged #908 and #913 The date in the file is now 2024-11-15. |
zvr
approved these changes
Nov 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will be merge when we are happy to freeze the 3.0.1 and make tag release of the 3.0.1 model.
See change log update for the spec at spdx/spdx-spec#1123