Skip to content

SPDX Lite annex - #1061

Merged
goneall merged 4 commits into
spdx:development/v3.0.1from
zvr:lite
Aug 12, 2024
Merged

goneall merged 4 commits into
spdx:development/v3.0.1from
zvr:lite

Conversation

@zvr

@zvr zvr commented Aug 12, 2024

Copy link
Copy Markdown
Member

This re-words the Lite annex to make it easier to understand the mandatory and recommended properties defined.

It also changes the format to use lists instead of tables, so that it can be generated in PDF.

Signed-off-by: Alexios Zavras github@zvr.gr

Signed-off-by: Alexios Zavras <github@zvr.gr>
@zvr zvr added this to the 3.0.1 milestone Aug 12, 2024
@zvr

zvr commented Aug 12, 2024

Copy link
Copy Markdown
Member Author

@NorioKobota please take a look

@NorioKobota

Copy link
Copy Markdown
Contributor

@zvr Thanks, looks great.

@zvr
zvr requested review from bact, goneall and kestewart August 12, 2024 09:58
Comment thread docs/annexes/spdx-lite.md Outdated
Comment thread docs/annexes/spdx-lite.md Outdated

@bact bact left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed with @NorioKobota, make 4-space indent for nested list, for compatibility with both GitHub and MkDocs.

Also add a blank line between the headings and the following list, to ensure a proper display of the list on MkDocs.

Apart from the format, the content itself is good and ready to get approved.

Co-authored-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Alexios Zavras (zvr) <zvr+git@zvr.gr>
Comment thread docs/annexes/spdx-lite.md Outdated
zvr and others added 2 commits August 12, 2024 14:45
Signed-off-by: Alexios Zavras (zvr) <zvr+git@zvr.gr>
Co-authored-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Kate Stewart <13152682+kestewart@users.noreply.github.com>

@bobmartin3000 bobmartin3000 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goneall goneall left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kestewart kestewart left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed, and spacing adjusted.

@goneall
goneall merged commit 63b1eab into spdx:development/v3.0.1 Aug 12, 2024
@zvr zvr mentioned this pull request Aug 28, 2024
@zvr
zvr deleted the lite branch September 6, 2024 08:31
@bact bact added the profile: lite Lite profile and related matters label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

profile: lite Lite profile and related matters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants