Skip to content

Update Core diagram with IndividualElement + Security smaller filesize - #1163

Merged
bact merged 1 commit into
spdx:developfrom
bact:new-core-diagram-with-individualelement
Dec 12, 2024
Merged

Update Core diagram with IndividualElement + Security smaller filesize#1163
bact merged 1 commit into
spdx:developfrom
bact:new-core-diagram-with-individualelement

Conversation

@bact

@bact bact commented Dec 11, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator
  1. Update Core diagram, adding IndividualElement to the diagram
  2. Use smaller size PNGs from Reexport Core and Security diagram PNGs for smaller file size spdx-3-model#942 (no content changes)
    • Core size: 532 KB -> 245 KB
    • Security size: 434 KB -> 157 KB
    • No content or image dimension changes. Just removed draw.io editable vector metadata from the PNGs. Will help faster website loading

The (1) part of this PR is duplicated with #1161 which has a DCO issue.

@bact
Update Core diagram with IndividualElement
0ff3114 
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@bact bact added profile: security Security profile and related matters profile: core Core profile and related matters labels Dec 11, 2024
@bact bact added this to the 3.0.1 milestone Dec 11, 2024
@bact
bact requested review from goneall, kestewart and zvr December 11, 2024 08:54
@bact bact mentioned this pull request Dec 11, 2024
Closed
@bact

bact commented Dec 12, 2024

Copy link
Copy Markdown
Collaborator Author

@sbarnum would you mind review this please? So we can have the IndividualElement on our spec website. Thank you.

kestewart
kestewart approved these changes Dec 12, 2024
View reviewed changes

@kestewart kestewart left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bact!

@bact

bact commented Dec 12, 2024

Copy link
Copy Markdown
Collaborator Author

With two approvals, will merge this.
Will check the spec website again afterwards.

@bact
bact merged commit 918bf0b into spdx:develop Dec 12, 2024
@bact
bact deleted the new-core-diagram-with-individualelement branch December 12, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goneall goneall goneall approved these changes
@kestewart kestewart kestewart approved these changes
@zvr zvr Awaiting requested review from zvr

Assignees

No one assigned

Labels

profile: core Core profile and related matters profile: security Security profile and related matters

Projects

None yet

Milestone

3.0.1

Development

Successfully merging this pull request may close these issues.

3 participants

@bact @goneall @kestewart