Repository navigation
Validate only specific doc examples with SHACL in CI. - #935
Merged
goneall merged 1 commit intoApr 23, 2024
Merged
Conversation
The check assumes that JSON example snippets are all parts of a single JSON document that needs validating, but not all files are written that way. To avoid errors that have nothing to do with the correctness of the examples, we should only check files which meet the check's assumptions. Fixes spdx#912. Signed-off-by: Jeff Licquia <jeff@licquia.org>
Collaborator
Author
|
@JPEWdev GitHub wouldn't let me request you as a reviewer, but I'd appreciate a look-see to make sure I'm not missing something. |
JPEWdev
approved these changes
Apr 23, 2024
JPEWdev
left a comment
JPEWdev
left a comment
Contributor
There was a problem hiding this comment.
LGTM. we should figure out a way to validate the other documents, but this is fine in the mean time
goneall
approved these changes
Apr 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The check assumes that JSON example snippets are all parts of a single JSON document that needs validating, but not all files are written that way. To avoid errors that have nothing to do with the correctness of the examples, we should only check files which meet the check's assumptions.
Fixes #912.