Skip to content

Upgrade Google Java Format 1.24.0 -> 1.26.0 - #198

Merged
andreasfolkesson merged 7 commits into
spotify:mainfrom
vladimirconev:bump-google-formatter-version
Apr 30, 2025
Merged

andreasfolkesson merged 7 commits into
spotify:mainfrom
vladimirconev:bump-google-formatter-version

Conversation

@vladimirconev

Copy link
Copy Markdown
Contributor

Upgrade to latest Google Java Formatter v1.25.2 (https://github.com/google/google-java-format/releases/tag/v1.25.2)

@Stephan202

Copy link
Copy Markdown
Contributor

Unfortunately this won't work without further changes; see #195. I have yet to find time for a closer look. Perhaps you're up for that, @vladimirconev?

@vladimirconev

vladimirconev commented Dec 14, 2024 •

Copy link
Copy Markdown
Contributor Author

Using 11, upon upgrade to google formatter 1.25.2 there are some compilation issues. Changing Maven Runner to Java 17 and running 'mvn clean verify' builds successfully ([ERROR] The following builds was skipped:
[ERROR] * fork_never_beforejdk16\pom.xml due to JRE version).

@Stephan202

Copy link
Copy Markdown
Contributor

Based on past activity: @knifeofdreams or @andreasfolkesson are you okay with raising the build baseline to JDK 17 (required by google/google-java-format#1159), without modifying the build to cover that one JDK 11 test case? If so, it'd be great to have a release with this change and a bump to version 1.26.0.

(Other past maintainers of this repository include @caesar-ralf, @bryanlb and @klaraward, but based on their profile they no longer work at Spotify.)

@petedmarsh petedmarsh changed the title Upgrade Google Java Format 1.24.0 -> 1.25.2 Upgrade Google Java Format 1.24.0 -> 1.26.0 Apr 30, 2025
@petedmarsh
petedmarsh self-requested a review April 30, 2025 11:26
@petedmarsh petedmarsh closed this Apr 30, 2025
@petedmarsh petedmarsh reopened this Apr 30, 2025
andreasfolkesson and others added 3 commits April 30, 2025 14:12
Cache v2 has been deprecated. The error message said to upgrade to v3 or v4.
Ubuntu 20.04 is deprecated. Use latest supported version.
@andreasfolkesson
andreasfolkesson merged commit 4e1fd13 into spotify:main Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants