Skip to content

fix(launcher): handle QR code navigation - #11460

Merged
rafaeltonholo merged 1 commit into
thunderbird:mainfrom
Logeshsharma:fix/11276/scan-qr-code-navigation
Sep 2, 2026
Merged

rafaeltonholo merged 1 commit into
thunderbird:mainfrom
Logeshsharma:fix/11276/scan-qr-code-navigation

Conversation

@Logeshsharma

Copy link
Copy Markdown
Contributor

Handle ScanQrCode emitted by the Thunderbird account setup flow so the QR import screen opens when no account is configured.

Contribution Summary

Linked Issue/Ticket: Fixes #11276

Description

Handle ThundermailRoute.ScanQrCode in the launcher navigation flow.

Previously, when no account was configured, the account setup flow emitted
ThundermailRoute.ScanQrCode, but the launcher did not handle that route and
the action fell through without navigation.

This adds the missing navigation branch so the QR import screen opens correctly.

Screen Recording

handle.QR.code.navigation.mp4

Testing

  • Reproduced the issue with no configured accounts.
  • Verified that Scan QR code opens after the fix.
  • Verified that the existing-account QR flow still works.
  • I couldn't find existing tests covering this launcher navigation path. Happy to add regression coverage if there is a preferred testing approach for this area.

AI Disclosure

Select one of the following (mandatory)

  • This contribution does not include any changes created or assisted by AI.
  • This contribution includes changes assisted by AI.
  • This contribution includes changes created by AI.

Contribution Checklist

  • I have read and affirm that my contribution adheres to Mozilla’s Community Participation Guidelines
  • This contribution is in Kotlin where possible
  • This contribution does not use merge commits
  • This contribution adheres to the existing codestyle (run gradlew spotlessCheck to check and gradlew spotlessApply to format your source code; will be checked by CI).
  • This contribution does not break existing unit tests (run gradlew testDebugUnitTest; will be checked by CI).
  • This contribution includes tests for any new functionality, and maintains tests for any updated functionality.
  • This contribution adheres to our Engineering process (RFC/Technical Design/ADR)
  • This PR has a descriptive title and body that accurately outlines all changes made, and contains a reference to any issues that it fixes (e.g. Closes #XXX or Fixes #XXX).

Handle ScanQrCode emitted by the Thunderbird account setup flow so the QR import screen opens when no account is configured.

Fixes thunderbird#11276
@github-actions

github-actions Bot commented Aug 28, 2026 •

Copy link
Copy Markdown
Contributor

✅ Validation Passed: All report and feature-flag labels are correctly set.

@rafaeltonholo rafaeltonholo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this contribution

@rafaeltonholo
rafaeltonholo merged commit b6a6626 into thunderbird:main Sep 2, 2026
19 of 20 checks passed
@thunderbird-botmobile

Copy link
Copy Markdown
Contributor

Thanks for your contribution! Your pull request has been merged and will be part of Thunderbird 24. We appreciate the time and effort you put into improving Thunderbird. If you haven’t already, you’re welcome to join our Matrix chat for contributors. It’s where we discuss development and help each other out. https://matrix.to/#/#tb-android-dev:mozilla.org
Hope to see you there! 🚀📱🐦

@thunderbird-botmobile thunderbird-botmobile Bot added this to the Thunderbird 24 milestone Sep 2, 2026
@Logeshsharma
Logeshsharma deleted the fix/11276/scan-qr-code-navigation branch September 3, 2026 14:52

This branch was previously deployed

2 inactive deployments
botmobile — b7d2e41b Deployed Sep 2, 2026 by rafaeltonholo via pr-merged #462
review — b7d2e41b Deployed Aug 28, 2026 by Logeshsharma via label-tb-team #455
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

report: include Include changes in user-facing reports.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Account cannot be added on TfA 22.0b1 via QR code on fresh install

2 participants