Skip to content

fix(apiserver): grant WAF v3 RBAC to network-admin and ui-user roles - #4964

Merged
electricjesus merged 1 commit into
masterfrom
seth/ev-6723-network-admin-waf-rbac
Jun 25, 2026
Merged

electricjesus merged 1 commit into
masterfrom
seth/ev-6723-network-admin-waf-rbac

Conversation

@electricjesus

Copy link
Copy Markdown
Member

Description

Bug fix. The tigera-network-admin (Cluster Operator) and read-only tigera-ui-user ClusterRoles both granted the operator.tigera.io/applicationlayers toggle (enable/disable WAF) but had no rule for the applicationlayer.projectcalico.org WAF v3 resources. As a result, a user bound to tigera-network-admin could not create/manage β€” and a tigera-ui-user could not view β€” GlobalWAFPolicy, GlobalWAFPlugin, GlobalWAFValidationPolicy, or the namespaced WAFPolicy/WAFPlugin/WAFValidationPolicy resources.

This adds:

  • tigera-network-admin: create, update, delete, patch, get, watch, list on the WAF v3 resources (mirrors the existing network policy grants).
  • tigera-ui-user: get, watch, list (read-only parity).

Components: apiserver render (pkg/render/apiserver.go) β€” RBAC only. No API/CRD or version changes.

Testing: TDD (failing fixture first, then implementation). Full pkg/render unit suite passes: 546 Passed | 0 Failed.

Issue: https://tigera.atlassian.net/browse/EV-6723

Release Note

Granted the tigera-network-admin and tigera-ui-user roles RBAC access to the WAF (applicationlayer.projectcalico.org) policy resources.

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files (n/a β€” no API change)
  • If changing versions, run make gen-versions (n/a β€” no version change)

For PR reviewers

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug β€” bugfix.
    • enterprise β€” Calico Enterprise only.

@electricjesus
electricjesus requested a review from a team as a code owner June 25, 2026 09:13
@electricjesus electricjesus added kind/bug Something isn't working enterprise Feature applies to enterprise only release-note-required labels Jun 25, 2026
@marvin-tigera marvin-tigera added this to the v1.44.0 milestone Jun 25, 2026
Neither tigera-network-admin (the Cluster Operator role) nor the
read-only tigera-ui-user role had access to the
applicationlayer.projectcalico.org WAF resources, so operators could not
manage β€” and viewers could not see β€” GlobalWAFPolicy, GlobalWAFPlugin,
GlobalWAFValidationPolicy, or the namespaced waf* resources.

Grant tigera-network-admin full CRUD + list/watch, and tigera-ui-user
get/list/watch, on those resources alongside the existing policy grants.

EV-6723
@electricjesus
electricjesus force-pushed the seth/ev-6723-network-admin-waf-rbac branch from bd62e59 to 0b8a1d2 Compare June 25, 2026 11:21
@electricjesus
electricjesus merged commit 1a0f9d6 into master Jun 25, 2026
6 checks passed
@electricjesus
electricjesus deleted the seth/ev-6723-network-admin-waf-rbac branch June 25, 2026 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-pr-required enterprise Feature applies to enterprise only kind/bug Something isn't working release-note-required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants