Repository navigation
fix(apiserver): grant WAF v3 RBAC to network-admin and ui-user roles - #4964
Merged
Merged
Conversation
Neither tigera-network-admin (the Cluster Operator role) nor the read-only tigera-ui-user role had access to the applicationlayer.projectcalico.org WAF resources, so operators could not manage β and viewers could not see β GlobalWAFPolicy, GlobalWAFPlugin, GlobalWAFValidationPolicy, or the namespaced waf* resources. Grant tigera-network-admin full CRUD + list/watch, and tigera-ui-user get/list/watch, on those resources alongside the existing policy grants. EV-6723
electricjesus
force-pushed
the
seth/ev-6723-network-admin-waf-rbac
branch
from
June 25, 2026 11:21
bd62e59 to
0b8a1d2
Compare
jaderhs
approved these changes
Jun 25, 2026
2 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bug fix. The
tigera-network-admin(Cluster Operator) and read-onlytigera-ui-userClusterRoles both granted theoperator.tigera.io/applicationlayerstoggle (enable/disable WAF) but had no rule for theapplicationlayer.projectcalico.orgWAF v3 resources. As a result, a user bound totigera-network-admincould not create/manage β and atigera-ui-usercould not view βGlobalWAFPolicy,GlobalWAFPlugin,GlobalWAFValidationPolicy, or the namespacedWAFPolicy/WAFPlugin/WAFValidationPolicyresources.This adds:
tigera-network-admin:create, update, delete, patch, get, watch, liston the WAF v3 resources (mirrors the existing network policy grants).tigera-ui-user:get, watch, list(read-only parity).Components: apiserver render (
pkg/render/apiserver.go) β RBAC only. No API/CRD or version changes.Testing: TDD (failing fixture first, then implementation). Full
pkg/renderunit suite passes:546 Passed | 0 Failed.Issue: https://tigera.atlassian.net/browse/EV-6723
Release Note
For PR author
make gen-files(n/a β no API change)make gen-versions(n/a β no version change)For PR reviewers
kind/bugβ bugfix.enterpriseβ Calico Enterprise only.