Repository navigation
[v3.23] fix(operator): drop emSign roots from the system CA bundle - #5365
Merged
rene-dekker merged 1 commit intoOct 22, 2026
Merged
Conversation
The operator mounts its own UBI root store into pods that need public roots. That store still carries the four eMudhra (emSign) roots, and emSign ECC Root CA - G3 anchors intermediates whose private keys were recovered (RHSB-2026-012). Filter all four out by SHA-256 fingerprint in getSystemCertificates(), keeping every other byte of the bundle. Also wrap the read error with %w instead of passing it to Sprintf. (cherry picked from commit 5f70d1e8f3 in tigera/calico-private)
Behnam-Shobiri
approved these changes
Oct 22, 2026
rene-dekker
approved these changes
Oct 22, 2026
7 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of https://github.com/tigera/calico-private/pull/14857.
Applied with
git am -p2. The only conflict was one context line under the new function (TrustedBundleNamediffers on this branch); the function body matches master. The test import path isgithub.com/tigera/operator/...here.go test ./pkg/tls/certificatemanagement/ ./pkg/controller/certificatemanager/passes on release-v1.42.Description
The operator copies its own UBI root store into the
tigera-ca-bundleconfigmap (keyca-bundle.crt). It mounts that store into every pod that needs public roots. That store still has the four eMudhra (emSign) roots.emSign ECC Root CA - G3anchors the eMudhra intermediates whose private keys were recovered (RHSB-2026-012, https://bugzilla.mozilla.org/show_bug.cgi?id=2084101). Red Hat has not shipped a fixedca-certificatesyet.This change drops the four emSign roots from the bundle.
getSystemCertificates()now runs the file throughfilterDistrustedCertificates(). That function drops any PEM block whose SHA-256 fingerprint is on a short list and keeps every other byte.Why this is enough for the pods that use the bundle:
emSign ECC Root CA - G3, the other to Sectigo'sAAA Certificate Services. The UBI bundle does not hold the Sectigo root. So once G3 is gone, no path to the cracked keys is left./etc/pki/tls/certs/and/etc/pki/tls/cert.pem. Go and OpenSSL read those first, so the unfiltered copies elsewhere in an image are never read.What this does not cover (follow-ups):
cacerts, which holds both roots. Kibana trusts Node's built-in roots. Neither uses this bundle.cert.pemmount is skipped. Go uses CryptoAPI and Ruby uses RubyInstaller's owncert.pem.SplunkFluentdSecretCertificateKeyis never wired).Also fixes the error in the same function:
fmt.Errorfhad no%w, so a read error came out garbled and was not wrapped.Rollout:
hash.operator.tigera.io/systemchanges once, because every current image has these roots. So node, typha, dex, fluentd, eks-log-forwarder, intrusion detection, webhooks-processor and guardian (Public CA) restart once on upgrade.Breaking for a few setups: a customer endpoint whose certificate chains to an emSign root will fail TLS after this. That covers Splunk HEC, syslog over TLS and S3-compatible stores. For syslog, the
syslog-caconfigmap is the workaround today.operator/is shared with OSS, so projectcalico/calico needs the same change.Picking to tigera/operator
release-v1.42: the paths there have nooperator/prefix, so usegit am -p2. Expect a one-line context conflict under the new function, becauseTrustedBundleNamediffers there.Test plan:
pkg/tls/certificatemanagement: each of the four emSign roots is dropped, another root is kept, and the output parses. A bundle with no emSign root comes back byte for byte, and nil stays nil.v1.42.6-25-g4d78391b829c): 146 roots in, 142 out, 0 emSign left.go testpasses forpkg/tls/certificatemanagement,pkg/controller/certificatemanagerandpkg/enterprise/render/dex. gofmt and vet are clean.Release Note
AI assistance: This PR was written in part with the assistance of generative AI.
For PR author
make gen-files(N/A, no pkg/apis/ changes)make gen-versions(N/A, no version changes)For PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bugif this is a bugfix.kind/enhancementif this is a a new feature.enterpriseif this PR applies to Calico Enterprise only.