Repository navigation
[release-v1.44] Let calico-apiserver update ippools/status - #5389
Merged
Merged
Conversation
Port of projectcalico/calico#14528. Creating an IPPool through the v3 API marks it Allocatable via the status subresource. The calico-crds ClusterRole lacked ippools/status, so every pool create logged a forbidden error. The manifest install already grants it.
lwr20
marked this pull request as ready for review
November 6, 2026 10:13
caseydavenport
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This ports PR 14528 (calico-apiserver
ippools/statusRBAC) to release-v1.44, which Calico OSS v3.33 pins.Creating an IPPool through the v3 API marks it
Allocatablevia the status subresource (libcalico-go/lib/clientv3/ippool.gomarkAllocatable, on calico release-v3.33 since #13953). Thecalico-crdsClusterRole grantsippoolsbut notippools/status, so in operator installs every pool create logs:manifests/apiserver.yaml):crd.projectcalico.orgippools/statusupdate.go build ./pkg/render/and the render unit tests. The existing tests only check that the role exists.Release Note
AI assistance: Claude Code found the error in e2e component logs, traced the missing rule, and wrote the change.
By opening this PR you take responsibility for every line in it, and you agree to explain the change yourself during review rather than routing review comments back through an agent.
For PR author
make gen-filesmake gen-versionsFor PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bugif this is a bugfix.kind/enhancementif this is a a new feature.enterpriseif this PR applies to Calico Enterprise only.