Skip to content

[release-v1.44] Let calico-apiserver update ippools/status - #5389

Merged
lwr20 merged 1 commit into
tigera:release-v1.44from
lwr20:ippool-status-rbac-v1.44
Nov 6, 2026
Merged

lwr20 merged 1 commit into
tigera:release-v1.44from
lwr20:ippool-status-rbac-v1.44

Conversation

@lwr20

@lwr20 lwr20 commented Nov 6, 2026

Copy link
Copy Markdown
Member

Description

This ports PR 14528 (calico-apiserver ippools/status RBAC) to release-v1.44, which Calico OSS v3.33 pins.

Creating an IPPool through the v3 API marks it Allocatable via the status subresource (libcalico-go/lib/clientv3/ippool.go markAllocatable, on calico release-v3.33 since #13953). The calico-crds ClusterRole grants ippools but not ippools/status, so in operator installs every pool create logs:

ippools.crd.projectcalico.org "test-pool" is forbidden: User "system:serviceaccount:calico-system:calico-apiserver" cannot update resource "ippools/status" in API group "crd.projectcalico.org" at the cluster scope
  • Impact. The failure is non-fatal, because kube-controllers' pool controller sets the condition itself. It shows up on every operator lane in the calico release-v3.33 e2e runs, though, and trips the component-log check.
  • Fix. Adds the same rule the manifest install already has (manifests/apiserver.yaml): crd.projectcalico.org ippools/status update.
  • Port. The change applied cleanly.
  • Testing. go build ./pkg/render/ and the render unit tests. The existing tests only check that the role exists.

Release Note

Fixed calico-apiserver being denied when it marks a new IPPool allocatable in operator-managed installs (missing ippools/status RBAC).

AI assistance: Claude Code found the error in e2e component logs, traced the missing rule, and wrote the change.

By opening this PR you take responsibility for every line in it, and you agree to explain the change yourself during review rather than routing review comments back through an agent.

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

Port of projectcalico/calico#14528. Creating an IPPool through the v3
API marks it Allocatable via the status subresource. The calico-crds
ClusterRole lacked ippools/status, so every pool create logged a
forbidden error. The manifest install already grants it.
@lwr20 lwr20 added the kind/bug Something isn't working label Nov 6, 2026
@marvin-tigera marvin-tigera added this to the v1.44.1 milestone Nov 6, 2026
@lwr20
lwr20 marked this pull request as ready for review November 6, 2026 10:13
@lwr20
lwr20 requested a review from a team as a code owner November 6, 2026 10:13
@lwr20
lwr20 merged commit 64918a5 into tigera:release-v1.44 Nov 6, 2026
7 checks passed
@danudey danudey added the kind/bug Something isn't working label Nov 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants