Repository navigation
fix(api): guard lazy import exit hook - #861
Merged
Merged
Conversation
The Python 3.15 runtime in tox-dev#860 lacks types.LazyImportType, but lock construction still registers a hook that reads it at exit. Check for the type before registering the hook.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Python 3.15 runtime reported in #860 lacks
types.LazyImportType. Creating a lock registers an exit hook that later raisesAttributeErrorwhen it tries to read that attribute.Fixes #860 by registering the hook only when the lazy import proxy type exists. Runtimes with the type retain the shutdown handling; runtimes without it avoid the failing callback.