Repository navigation
🐛 fix(soft): restore raced stale markers - #899
Merged
Merged
Conversation
An exchange can succeed during takeover, then the filesystem can refuse it while unwinding. Retrying forever wedges acquire; deleting the contender's marker exposes an empty path beside a live holder. Stop on refusal and retain the marker for later recovery.
gaborbernat
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three or more contenders reclaiming a dead soft-lock marker can strand a live holder's marker under a break name. The lock may then become unusable or admit a second holder. This affects
SoftFileLock,MarkerSoftFileLock, andSoftFileLeaseon filesystems that support atomic name exchange.Contenders now check the marker again before exchanging names and unwind nested exchanges in order. If the filesystem refuses a return exchange, the contender leaves its marker at the lock path for later recovery, so another process cannot claim an empty path.