Skip to content

πŸ› fix(lease): reclaim dead holders after duration changes - #900

Merged
gaborbernat merged 2 commits into
tox-dev:mainfrom
dxbjavid:lease-dead-holder-duration
Nov 2, 2026
Merged

gaborbernat merged 2 commits into
tox-dev:mainfrom
dxbjavid:lease-dead-holder-duration

Conversation

@dxbjavid

@dxbjavid dxbjavid commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

After a lease holder crashed, peers restarted with a different lease_duration could not acquire the lock because the dead marker raised LeaseSettingsMismatch. They can now reclaim that marker without an operator calling force_break().

Duration agreement still protects live lease holders: contenders reject a live marker published with another duration, while stale-owner detection takes precedence once the recorded process is provably gone.

@gaborbernat gaborbernat added the bug label Nov 2, 2026
@gaborbernat gaborbernat changed the title fix(lease): reclaim a dead holder published with another duration πŸ› fix(lease): reclaim dead holders after duration changes Nov 2, 2026
@gaborbernat
gaborbernat enabled auto-merge (squash) November 2, 2026 15:56

@gaborbernat gaborbernat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaborbernat
gaborbernat disabled auto-merge November 2, 2026 16:05
@gaborbernat
gaborbernat merged commit ff84735 into tox-dev:main Nov 2, 2026
50 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants