Repository navigation
🐛 fix(api): expire at the exact timeout - #922
Merged
Merged
Conversation
Clipping each poll to the remaining time can leave a virtual clock exactly at the deadline. The strict comparison then retries with sleep(0) forever. Treat the deadline as expired after a failed acquisition and cover the boundary with Unix and soft locks. Fixes tox-dev#920
gaborbernat
force-pushed
the
fix/timeout-boundary-920
branch
from
November 9, 2026 17:21
f0670a6 to
f2fea5d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
U-Boot's buildman process-limit test can leave a contended filelock retrying at its timeout boundary when the test's virtual clock stops advancing (#920). A caller waiting for that lock now receives
Timeoutat the deadline.The shared acquisition path decides when a wait has expired for both Unix and soft locks. It still attempts to acquire a lock before checking the deadline, so an available lock can be acquired with a zero timeout.