Fix fdisk detection on BusyBox systems - #3614
Merged
Merged
Conversation
On BusyBox, fdisk -v exists but returns a non-zero exit code, causing the script to incorrectly conclude fdisk is not available. Use POSIX command -v instead to reliably check for fdisk.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On BusyBox systems,
fdisk -vexists but returns a non-zero exit code, causing the script inINSTALL/tool/VentoyWorker.shto incorrectly conclude fdisk is not available. This prevents Ventoy from using fdisk as a partition tool on those systems.Changed the detection from
fdisk -v >/dev/null 2>&1tocommand -v fdisk > /dev/null 2>&1, which is POSIX-compliant and works reliably regardless of the command's flag behavior.