Repository navigation
builder,pref: Allow thirdparty objects compilation with CPP compiler - #19124
Merged
spytheman merged 8 commits intoAug 13, 2023
Merged
Conversation
spytheman
approved these changes
Aug 13, 2023
spytheman
left a comment
Contributor
There was a problem hiding this comment.
Good work. It does need a small test to keep it from regressing. I'll add it asap.
spytheman
force-pushed
the
feature/thirdparty-cpp-compilation
branch
from
August 13, 2023 10:14
921b5a4 to
52536f6
Compare
spytheman
force-pushed
the
feature/thirdparty-cpp-compilation
branch
from
August 13, 2023 15:29
810cb79 to
5bc50c5
Compare
Wertzui123
pushed a commit
to Wertzui123/v
that referenced
this pull request
Oct 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
As I was working on a binding for an external CPP library, I was hit by:
This PR enable one to bind and build such binding, by keeping the
#flag @VEXEROOT/thirdparty/path/to/object.ocompatibilty.Kind regards,
🤖 Generated by Copilot at 231859a
This pull request adds support for custom C++ compilers in V and enables compiling third party modules that use C++ code. It modifies the
Preferencesstruct, thecc.vandpref.vfiles, and adds a-c++flag to choose the compiler.🤖 Generated by Copilot at 231859a
vlib/v/builder/cc.v(link)no_stdpreference (link)thirdparty_object_argsfunction (link, link)thirdparty_object_argsfunction based on OS,no_stdpreference, and file type (link)build_thirdparty_obj_filefunction (link)build_thirdparty_obj_filefunction (link)default_ccompilerfunction invlib/v/pref/default.v(link)default_cpp_compilerfunction toPreferencesstruct invlib/v/pref/default.v(link)cppcompilerfield toPreferencesstruct invlib/v/pref/pref.v(link)-c++option to command line parser invlib/v/pref/pref.v(link)