Repository navigation
checker: disallow ptr assignments to consts with int literal vals - #19160
Merged
Merged
Conversation
ttytm
marked this pull request as draft
August 17, 2023 14:53
JalonSolov
reviewed
Aug 17, 2023
| 4 | b := &a | ||
| | ^ | ||
| 5 | } | ||
| Details: Specify the type for the constant value. Example: |
Collaborator
There was a problem hiding this comment.
Seems like these details should come after the error message.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Member
Author
There was a problem hiding this comment.
Though I should not make the added tests produce an unused error
spytheman
approved these changes
Aug 17, 2023
ttytm
marked this pull request as ready for review
August 17, 2023 18:55
Wertzui123
pushed a commit
to Wertzui123/v
that referenced
this pull request
Oct 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #19146
🤖 Generated by Copilot at 8c04366
Prevent assigning pointers to integer constants in the V compiler. Improve error message and suggestion for constant declarations.
🤖 Generated by Copilot at 8c04366