[jameskirkwood]

This PR changes (SSLListener) accept() in vlib/net/mbedtls/ssl_connection.v so that the client connection socket it creates will be closed by (SSLConn) shutdown().

Without this change, shutdown() does not close connections created by accept() and clients that are designed to keep receiving (or sending) data until the server closes the connection will be left to time out. This makes it difficult to implement the Gemini protocol, for example.

[spytheman]

Can you add a small test please?

[jameskirkwood]

Can you add a small test please?

Sure.

I'm new to the code base and language -- Would it be appropriate to rename the existing test file mbedtls_sslconn_shutdown_does_not_panic_test.v to be less specific and add a new test_ function to it? If so, should it be mbedtls_test.v, ssl_listener_test.v or ssl_connection_test.v? Alternatively I suppose I might create that file without touching mbedtls_sslconn_shutdown_does_not_panic_test.v. I would like to avoid duplicating the test server config though.

[spytheman]

You can rename it to mbedtls_test.v, then add a fn test_shutdown_closes_accepted_connections() { in it.

[trufae]

i can confirm this patch fixes the issue 👍

[medvednikov]

It's an important fix, I'll merge it for now without a test.