Repository navigation
cgen: allow constant as enum value - #19193
Merged
Merged
Conversation
yuyi98
approved these changes
Aug 21, 2023
spytheman
marked this pull request as ready for review
August 21, 2023 08:13
spytheman
approved these changes
Aug 21, 2023
spytheman
marked this pull request as draft
August 21, 2023 08:28
felipensp
marked this pull request as ready for review
August 22, 2023 12:17
spytheman
approved these changes
Aug 22, 2023
Wertzui123
pushed a commit
to Wertzui123/v
that referenced
this pull request
Oct 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #19115
π€ Generated by Copilot at 065e34e
Fix issue #11176 with enum fields with constant expressions. Resolve the expressions in the checker and use the correct values in the code generation.
π€ Generated by Copilot at 065e34e
checker.vif it is a constant or unresolved (link)cgen.vif the expression is an identifier from a C header file (link)