Repository navigation
math.fractions: use operator overloading and deprecate old functions - #19547
Merged
medvednikov merged 2 commits intoOct 11, 2023
Merged
Conversation
yuyi98
approved these changes
Oct 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated by Copilot at 7737f70
Improved the
Fractiontype in themath/fractionsmodule by using standard operators for equality and comparison, and making thereducemethod return a new value instead of modifying the original one. This makes theFractiontype more consistent and easier to use.🤖 Generated by Copilot at 7737f70
equals,lt,le,gt, andgemethods of theFractionstruct and replaced them with==,<,<=,>, and>=operators, respectively, to make the code more idiomatic and consistent with other types in V. (link, link, link, link, )fraction_test.vto use the new operators instead of the deprecated methods. (link, link, link, link, link, link, link, link, link, link)reducemethod of theFractionstruct to return a newFractioninstead of modifying the original one, to make it more pure and functional. ( link)