Skip to content

net: fix handling of spurious wake-up signals lost when calling select() in mbedtls and openssl - #19600

Merged
spytheman merged 1 commit into
vlang:masterfrom
shove70:http
Oct 19, 2023
Merged

spytheman merged 1 commit into
vlang:masterfrom
shove70:http

Conversation

@shove70

@shove70 shove70 commented Oct 19, 2023

Copy link
Copy Markdown
Contributor
  1. This PR fixed handling of spurious wake-up signals lost when calling select() in mbedtls and openssl.
  2. Significantly reduced issue multithread http.get() errors #19580 exception response messages.
  3. There are many reasons of issue multithread http.get() errors #19580. I will continue to submit PR to solve other small problems. It also needs to be kept open.
Shoves-MacBook:temp shove$ v a.v
Shoves-MacBook:temp shove$ ./a
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200
200

@shove70

shove70 commented Oct 19, 2023

Copy link
Copy Markdown
Contributor Author
...
SSL handshake failed
200
200
200
SSL handshake failed
...

The SSL handshake failed message is a normal error message that the server has broken the connection due to security policies, QPS restrictions, and so on

@spytheman spytheman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@spytheman

Copy link
Copy Markdown
Contributor

I think that the @select function in vlib/net/common.v will need something similar too.

@shove70

shove70 commented Oct 19, 2023

Copy link
Copy Markdown
Contributor Author

OK, I take a look 👍

@spytheman
spytheman merged commit 772eb1e into vlang:master Oct 19, 2023
@shove70
shove70 deleted the http branch October 19, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants