Skip to content

fix crlf files modif on Windows - #20101

Merged
spytheman merged 2 commits into
vlang:masterfrom
dmitryuck:fix_comments_formatting
Dec 8, 2023
Merged

fix crlf files modif on Windows#20101
spytheman merged 2 commits into
vlang:masterfrom
dmitryuck:fix_comments_formatting

Conversation

@dmitryuck

@dmitryuck dmitryuck commented Dec 6, 2023

Copy link
Copy Markdown
Contributor

fix for this #20069

@dmitryuck dmitryuck mentioned this pull request Dec 6, 2023
Merged
@spytheman

spytheman commented Dec 6, 2023

Copy link
Copy Markdown
Contributor

Please also add a test in vlib/os, that writes a file containing newlines using a wb mode, and then reads and compares it.

@spytheman
spytheman merged commit 75c0c92 into vlang:master Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dmitryuck @spytheman