Skip to content

tools.shader: simplify, remove redundancies - #20161

Merged
spytheman merged 2 commits into
vlang:masterfrom
ttytm:tools.shader/simplify
Dec 13, 2023
Merged

spytheman merged 2 commits into
vlang:masterfrom
ttytm:tools.shader/simplify

Conversation

@ttytm

@ttytm ttytm commented Dec 12, 2023 •

Copy link
Copy Markdown
Member

related to: #20156 (comment)

Viewing the changes split into the two commits, makes it hopefully easier two spot the unnecessary compilation and redundancy.

πŸ€–[deprecated] Generated by Copilot at 3b79958

Refactored vshader.v to streamline sokol shader compilation. Removed unnecessary code and made it platform-independent.

πŸ€–[deprecated] Generated by Copilot at 3b79958

  • Rename shdc variable to shdc_exe for clarity and consistency (link, link, link)
  • Remove redundant shdc_exe function and inline its body (link, link)
  • Replace file variable with shdc_exe and simplify os.mv logic (link, link)

@spytheman spytheman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work.

@spytheman
spytheman merged commit 17bf8d1 into vlang:master Dec 13, 2023
@ttytm
ttytm deleted the tools.shader/simplify branch December 15, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants