Repository navigation
pref: disable -macosx-version-min clang flag by default - #20297
Merged
Merged
Conversation
Contributor
|
Please try |
Member
Author
Member
Author
|
Actually, all gg examples seem to be broken for me. I can't run 2048, flappylearning-v, or anything in examples/gg. They are all blank (white, or black, it seems) windows. So I can't run any of them in with any branch or command line arguments at the moment! |
Contributor
|
Well, at least with your changes, it compiled, which is better than a cgen error, due to the missing library π€ . |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Disable the
-macosx-version-minclang flag which is poorly documented, but which seems to affect STL (and some other headers) and also which runtime is linked against.This flag causes problems (on my Intel-based mac, at least), such as
C.environcauses segfaultos.Process._spawn()segfaultsThis results in total breakage of some v commands, including
v runandv test. E.g.,v runsegfaults as follows:This PR changes default behaviour of V compiler so that it does not pass a min macosx version to clang by default.