Repository navigation
checker: fix being too strict with generics in assignment type mismatch checking - #20346
Merged
Merged
Conversation
spytheman
approved these changes
Jan 2, 2024
spytheman
left a comment
spytheman
left a comment
Contributor
There was a problem hiding this comment.
Excellent work. Thank you very much.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #20335
This PR is a patch to PR #20327, temporarily relaxing the mismatch check on generic types. :)
discord.von the submitted 94d5563 can already be compiled properly.At present, the type mismatch check on assignment is too lenient for generics, and there will be some missed cases. I have written it down in a memo and arranged time for detailed handling