Repository navigation
ast: make Scope.find methods more robust, when called on default initialised scope &Scope = unsafe { nil } fields - #20774
Merged
spytheman merged 2 commits intoFeb 10, 2024
Conversation
…ialised `scope &Scope = unsafe { nil }` fields
This was referenced Feb 10, 2024
nkoehring
reviewed
Feb 10, 2024
|
One could also add a test, if all the tables are included. Not sure, if that is not already exhaustively tested, somewhere. One could otherwise add something like: nr_tables := db.exec('select count(*) from sqlite_master')!.first()
assert nr_tables.vals.first().int() >= 2 // result is probably bigger than 2, because of auto index tables |
Contributor
Author
|
This is a test for a compiler error, its purpose is not to test actual behavior of the ORM or db.sqlite. It is enough as it is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #18324 .