Repository navigation
fmt: fix formatting for imports of submodule from module src dir - #21060
Merged
spytheman merged 3 commits intoMar 19, 2024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #19799
With the linked PR vfmt won't break the import anymore. I think, since it's a working import it's okay when fmt just keeps it for now. Eventually we can check if a module placed in the
srcdir of a parent module is recognize when importing it without the src dir likeimport artemkakun.textproc.punctuationand let vfmt do the job of removing thesrc.part - currently, the module would not be found.