Skip to content

utils: fix module lookup if module import parts end with the word modules - #21083

Merged
spytheman merged 4 commits into
vlang:masterfrom
ttytm:utils/fix-module-lookup
Mar 24, 2024
Merged

spytheman merged 4 commits into
vlang:masterfrom
ttytm:utils/fix-module-lookup

Conversation

@ttytm

@ttytm ttytm commented Mar 23, 2024

Copy link
Copy Markdown
Member

Fixes #21078

Contains a little module import name correction.

Should we run the related example run in CI and add a info comment to not change the modules name?

@ttytm ttytm changed the title utils: fix module lookup if module import parts contains the word modules utils: fix module lookup if module import parts contain the word modules Mar 23, 2024
@ttytm ttytm changed the title utils: fix module lookup if module import parts contain the word modules utils: fix module lookup if module import parts end with the word modules Mar 23, 2024
@spytheman

spytheman commented Mar 24, 2024 •

Copy link
Copy Markdown
Contributor

Should we run the related example run in CI and add a info comment to not change the modules name?

Yes, that would be best. v build-examples uses only the absolute paths, and thus worked, while compiling with the relative path was a problem, and it went undetected.

@spytheman spytheman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@spytheman
spytheman merged commit f66b595 into vlang:master Mar 24, 2024
@ttytm
ttytm deleted the utils/fix-module-lookup branch March 25, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot compile examples/submodule

2 participants