Repository navigation
fmt: improve import processing, add test - #21172
Merged
Merged
Conversation
ttytm
force-pushed
the
fmt/import-code-quality
branch
14 times, most recently
from
April 2, 2024 16:48
3679000 to
5f21631
Compare
ttytm
force-pushed
the
fmt/import-code-quality
branch
from
April 2, 2024 23:08
d404c34 to
ddfe323
Compare
ttytm
force-pushed
the
fmt/import-code-quality
branch
from
April 2, 2024 23:12
ddfe323 to
78b4fe3
Compare
ttytm
force-pushed
the
fmt/import-code-quality
branch
from
April 3, 2024 13:58
b756a7e to
7e596a5
Compare
ttytm
changed the title
spytheman
approved these changes
Apr 3, 2024
spytheman
left a comment
spytheman
left a comment
Contributor
There was a problem hiding this comment.
Excellent work. Thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While deciding not to follow through on removing unused imports (for comprehensible reasons), working on #21169 provided insights allowing for general improvements. Picking the cherries, they should be integrated with this PR. It should serve as a base for further fix ups.
The feature of removing unused imports can still become a thing. It would fit better as as an action that can be triggered by a language sever on demand instead of being part of a formatter.