Repository navigation
parser: update file path fields; use more expressive name for file path, remove obsolete file_name_dir field - #21202
Merged
Merged
Conversation
ttytm
changed the title
ttytm
changed the title
spytheman
changed the title
file_name_dir field
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates file field names on the parser. Main concern was
file_nameholding the path and same data field is e.g. used on the scanner namedfile_path. Imho simpler to understand during development when reading file_path and understanding assignments to path related fields then doing so withfile_name.