Skip to content

ci: update binary_artifact.yml - #21364

Merged
spytheman merged 8 commits into
vlang:masterfrom
ttytm:ci/bin-artifcat
Apr 28, 2024
Merged

spytheman merged 8 commits into
vlang:masterfrom
ttytm:ci/bin-artifcat

Conversation

@ttytm

@ttytm ttytm commented Apr 27, 2024 •

Copy link
Copy Markdown
Member
  • Adds tiggers to include PRs updating this workflow, while the publishing and releasing part is limited to tag pushes.
  • Simplifes the current state without compromising on functionality where it can be appropriate, makes more consistent.
  • For macos-x86 macos-13 was set instead of macos-latest because macos-latest is migrating towards arm runners.

The workflow run under this PR should allow to manually inspect the crated binary artifacts.
edit: https://github.com/vlang/v/actions/runs/8860588557?pr=21364

Comment thread .github/workflows/binary_artifact.yml Outdated
Comment thread .github/workflows/binary_artifact.yml Outdated
Comment thread .github/workflows/binary_artifact.yml Outdated
Comment thread .github/workflows/binary_artifact.yml Outdated
Comment thread .github/workflows/binary_artifact.yml
Comment thread .github/workflows/binary_artifact.yml Outdated
Comment thread .github/workflows/binary_artifact.yml Outdated

@spytheman spytheman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work. It is now simpler and cleaner.

@spytheman

Copy link
Copy Markdown
Contributor

Can you please also add:
find |grep pdb$|xargs rm -rf
find |grep ilk$|xargs rm -rf
to the windows rm script?

image

It will reduce the size of the windows .zip file.

@ttytm

ttytm commented Apr 28, 2024

Copy link
Copy Markdown
Member Author

Good observation. Done πŸ‘

@spytheman
spytheman merged commit 53c941e into vlang:master Apr 28, 2024
@spytheman

Copy link
Copy Markdown
Contributor

Thank you πŸ™‡πŸ»β€β™‚οΈ .

@ttytm
ttytm deleted the ci/bin-artifcat branch April 28, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants