Repository navigation
ci: pass a good commit to oldv.v in bootstrapping_ci.yml - #21393
Merged
Merged
Conversation
ttytm
marked this pull request as draft
April 30, 2024 23:34
ttytm
force-pushed
the
ci/update-bootstrapping
branch
from
April 30, 2024 23:40
2cf6abe to
2a29a4d
Compare
ttytm
marked this pull request as ready for review
April 30, 2024 23:42
ttytm
force-pushed
the
ci/update-bootstrapping
branch
2 times, most recently
from
May 1, 2024 02:21
f270b49 to
662ba86
Compare
spytheman
reviewed
May 1, 2024
spytheman
reviewed
May 1, 2024
spytheman
reviewed
May 1, 2024
Member
Author
|
Looks like additional verification if a sha is still present on master is needed. In case of force pushes or why ever they are not available anymore? What do you think @spytheman? Edit: Oh okay, re-running can work too. Looks rather like it was a wrong api response. Failed run for reference: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes should be able to address: fd66067#commitcomment-141513977
A small change included here is a resolved linter complaint for the empty
B_CFLAGS: ''Would address it, but as the var is apparently not used it was removed.