Repository navigation
checker: fix unknown fixed array size - #21548
Merged
Merged
Conversation
Member
Author
|
Would require help to fixing the issue |
…ath { sin, cos }`"
This reverts commit ddf0468.
…_u8/1, overflows_u16/1, overflows_u32/1 helper predicates and use them
spytheman
marked this pull request as ready for review
May 23, 2024 14:53
spytheman
approved these changes
May 23, 2024
spytheman
reviewed
May 23, 2024
| return cast_expr_value.i64() or { return none } | ||
| } | ||
| if expr.typ == ast.int_type { | ||
| return cast_expr_value.i64() or { return none } |
Contributor
There was a problem hiding this comment.
I still do not understand why it has to be return cast_expr_value.i64() or { return none } here 🤔 ...
It would have been more logical to be cast_expr_value.int() instead, but this leads to an error later.
Member
Author
There was a problem hiding this comment.
I was thinking of using .int()as well but it errors later. I think it's due to int_literal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #21544