Repository navigation
cgen: fix auto str for fn struct member - #21825
Merged
Merged
Conversation
felipensp
marked this pull request as ready for review
July 8, 2024 13:39
spytheman
approved these changes
Jul 8, 2024
spytheman
left a comment
spytheman
left a comment
Contributor
There was a problem hiding this comment.
Excellent work.
The CI failures are not related imho. c2v and vdoom had recent changes, that may be responsible for them.
Delta456
reviewed
Jul 8, 2024
| func: implementation | ||
| } | ||
| println('${m}') | ||
| } No newline at end of file |
Member
There was a problem hiding this comment.
Minor but do add newline in the end of file
Delta456
reviewed
Jul 8, 2024
| @@ -0,0 +1,3 @@ | |||
| static string main__MyStruct_str(main__MyStruct it) { return indent_main__MyStruct_str(it, 0);} | |||
| static string main__Function_str() { return _SLIT("fn (int)");} | |||
| string _t1 = main__Function_str(); No newline at end of file | |||
Contributor
|
Thank you @felipensp |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #21823