Skip to content

checker: improve checks for embed in anon struct - #21877

Merged
spytheman merged 8 commits into
vlang:masterfrom
Delta456:struct_embed_anon
Jul 21, 2024
Merged

spytheman merged 8 commits into
vlang:masterfrom
Delta456:struct_embed_anon

Conversation

@Delta456

Copy link
Copy Markdown
Member

Fixes #21876

Comment thread vlib/v/parser/struct.v Outdated
@Delta456 Delta456 changed the title parser, checker: improve checks for embed in anon struct checker: improve checks for embed in anon struct Jul 16, 2024
@Delta456
Delta456 marked this pull request as ready for review July 16, 2024 12:24
Comment thread vlib/v/checker/checker.v
Comment thread vlib/v/checker/checker.v
@Delta456
Delta456 marked this pull request as draft July 20, 2024 07:01
@Delta456

Delta456 commented Jul 20, 2024 •

Copy link
Copy Markdown
Member Author

I have converted this PR into a draft and would require help.

EDIT: Issue resolved

@Delta456
Delta456 marked this pull request as ready for review July 20, 2024 09:02
Comment thread vlib/v/parser/tests/struct_anon_invalid_embed_err.out Outdated

@spytheman spytheman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@spytheman
spytheman merged commit b3b6ce5 into vlang:master Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

anonymous struct embedding lacks checks

3 participants