Repository navigation
flag: add optional value description to string parameters - #22024
Merged
Merged
Conversation
spytheman
reviewed
Aug 11, 2024
Contributor
I think it would be useful for the others too. |
spytheman
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using command line flags with string parameters, I found that the default val_desc values used were not as descriptive as I would like. And there was no way to override val_desc to a more descriptive value.
Using trailing struct literal arguments, I was able to add this capability without breaking any existing code.
I only did this for string parameters since that seemed to me to be the place where it would be most useful. It could easily be added to the other types if desired.