Repository navigation
encoding.utf8: fix is_punct func - #22647
Merged
Merged
Conversation
spytheman
reviewed
Oct 25, 2024
spytheman
reviewed
Oct 25, 2024
Co-authored-by: Delyan Angelov <delian66@gmail.com>
Co-authored-by: Delyan Angelov <delian66@gmail.com>
felipensp
marked this pull request as ready for review
October 25, 2024 13:56
spytheman
reviewed
Oct 25, 2024
spytheman
reviewed
Oct 25, 2024
StunxFS
reviewed
Oct 25, 2024
…to fix_utf8_is_punct
spytheman
reviewed
Oct 26, 2024
|
|
||
| import encoding.utf8 | ||
|
|
||
| fn test_true() { |
Contributor
There was a problem hiding this comment.
Suggested change
| fn test_true() { | |
| fn test_is_punct() { |
that will have all the cases for that specific public function will be a better scheme, so that if an assertion fails, the message will be more informative (the test function name is included in the failure)
Contributor
There was a problem hiding this comment.
However, the assertions themselves are already much better and direct, so the test function name does not matter as much 🤷🏻♂️ .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #22646
Huly®: V_0.6-21096