Repository navigation
cgen: fix codegen for -no-builtin flag - #22765
Merged
Merged
Conversation
felipensp
marked this pull request as ready for review
November 5, 2024 10:37
spytheman
approved these changes
Nov 5, 2024
spytheman
left a comment
spytheman
left a comment
Contributor
There was a problem hiding this comment.
Good work.
I usually also use -d no_main in combination with -no-builtin, but it is much better for those flags to be orthogonal/independent indeed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing compiling .c file from #22762 I noticed that
_vinit,_vcleanupare called but removed its declaration due -no-builtin flag, asg_main_argcandg_main_argvtoo.Huly®: V_0.6-21212