Repository navigation
log: tag log.fatal with @[noreturn] - #22986
Merged
Merged
Conversation
Delta456
approved these changes
Nov 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #22985
Copilot summary:
This pull request includes changes to the logging functionality in the
vlib/logmodule. The most important changes include adding the@[noreturn]attribute to thefatalfunction and introducing new test cases to ensure the correct behavior of the logging functions.Improvements to logging functionality:
vlib/log/default.v: Added the@[noreturn]attribute to thefatalfunction to indicate that it will not return, and ensured the function exits the program withexit(1)after logging a fatal message.Enhancements to test cases:
vlib/log/log_test.v: Added a new functionmake_errorand a test casetest_log_default_fatal_has_noreturnto verify that thefatalfunction behaves as expected and does not return.Huly®: V_0.6-21427