Repository navigation
checker: fix generic fn returning generic closure (fix #23035) - #23047
Merged
Merged
Conversation
spytheman
reviewed
Dec 2, 2024
Comment on lines
+270
to
+274
| // ignore return closure | ||
| if node.exprs[expr_idxs[i]] is ast.AnonFn | ||
| && node.exprs[expr_idxs[i]].inherited_vars.len > 0 { | ||
| continue | ||
| } |
Contributor
There was a problem hiding this comment.
will that allow for returning closures, that do not match the signature as well?
Member
Author
There was a problem hiding this comment.
Yes, It need to check more.
felipensp
approved these changes
Dec 2, 2024
Contributor
|
Great work! A neat fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fix generic fn returning generic closure (fix #23035).
Huly®: V_0.6-21487