Skip to content

cgen: fix different option alias type as fn arg - #23131

Merged
spytheman merged 3 commits into
vlang:masterfrom
felipensp:fix_option_alias_arg_diff
Dec 11, 2024
Merged

spytheman merged 3 commits into
vlang:masterfrom
felipensp:fix_option_alias_arg_diff

Conversation

@felipensp

@felipensp felipensp commented Dec 11, 2024 •

Copy link
Copy Markdown
Member

@spytheman spytheman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@spytheman
spytheman marked this pull request as ready for review December 11, 2024 14:06
@spytheman

Copy link
Copy Markdown
Contributor

I think the remaining CI job is very unlikely to fail, given the nature of the fix.

@spytheman
spytheman merged commit 77e4594 into vlang:master Dec 11, 2024
@felipensp
felipensp deleted the fix_option_alias_arg_diff branch December 11, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

invalid c code generation with generics, options and type aliases

2 participants