Repository navigation
cgen: fix codegen for returning option reference from indexexpr - #23139
Merged
Merged
Conversation
felipensp
marked this pull request as ready for review
December 11, 2024 21:15
spytheman
reviewed
Dec 12, 2024
spytheman
approved these changes
Dec 12, 2024
Member
Author
It will fails consistently running as sanitize tests, because the issue here is a stack-use-after-return issue. The extra prints stuff helps to trigger unexpected results... but I can clean up the code. |
Member
Author
|
Done @spytheman |
Contributor
Thank you 🙇🏻♂️ . |
spytheman
reviewed
Dec 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #23133 (stack-use-after-return bug)
Huly®: V_0.6-21576