Skip to content

scanner: fix string interpolation for float e format - #23147

Merged
spytheman merged 2 commits into
vlang:masterfrom
kbkpbot:fix-float-exponent
Dec 13, 2024
Merged

spytheman merged 2 commits into
vlang:masterfrom
kbkpbot:fix-float-exponent

Conversation

@kbkpbot

@kbkpbot kbkpbot commented Dec 13, 2024 •

Copy link
Copy Markdown
Contributor

Fix #22429

This is really a PR #22453 with improve tests.

Huly®: V_0.6-21584

@felipensp

Copy link
Copy Markdown
Member

But the pr is not handling the expoent part.

@kbkpbot

kbkpbot commented Dec 13, 2024 •

Copy link
Copy Markdown
Contributor Author

It seems vfmt remove the e in the string
'4.1e' => '4.1'
I will fix it later...

Comment thread vlib/v/tests/builtin_strings_and_interpolation/string_interpolation_test.v Outdated

@spytheman spytheman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@spytheman
spytheman merged commit c941c3d into vlang:master Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

checker,scanner: format specifier 'e' should not be recognized as exponent 'e'

4 participants