Repository navigation
checker,cgen: fix missing validation for selector unwrapping + fix default return none for unwrapping - #23183
Merged
Merged
Conversation
felipensp
changed the title
return none for unwrappingreturn none for unwrapping
felipensp
marked this pull request as ready for review
December 16, 2024 21:09
spytheman
approved these changes
Dec 16, 2024
spytheman
left a comment
spytheman
left a comment
Contributor
There was a problem hiding this comment.
Good find.
Excellent work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix missing selector checker for:
Return type was not required to be
?boolin this case.Beside this it was generating wrong none return code:
Huly®: V_0.6-21620