Skip to content

cgen: fix cgen error for instance.t.wait() on default 0 initialized thread field t (fix #23390) - #23392

Merged
spytheman merged 1 commit into
vlang:masterfrom
felipensp:cleanup_spawn_and_go
Jan 15, 2025
Merged

cgen: fix cgen error for instance.t.wait() on default 0 initialized thread field t (fix #23390)#23392
spytheman merged 1 commit into
vlang:masterfrom
felipensp:cleanup_spawn_and_go

Conversation

@felipensp

@felipensp felipensp commented Jan 6, 2025 •
edited by huly-for-github Bot
Loading

Copy link
Copy Markdown
Member

Cleanup
Fix #23390

@felipensp
felipensp marked this pull request as ready for review January 6, 2025 12:41
@felipensp felipensp changed the title cgen: cleanup spawn_and_go cgen: cleanup spawn_and_go and fix #23390 Jan 6, 2025
spytheman
spytheman approved these changes Jan 6, 2025
View reviewed changes

@spytheman spytheman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@felipensp

felipensp commented Jan 6, 2025

Copy link
Copy Markdown
Member Author

Excellent work.

It is failing on musl, should add an ignore clause there?

@spytheman

spytheman commented Jan 6, 2025

Copy link
Copy Markdown
Contributor

No, please leave it as it is for now.
I would like to reproduce it locally first, to see the actual difference.

@spytheman

spytheman commented Jan 7, 2025

Copy link
Copy Markdown
Contributor

Locally, after installing diffutils:

vlib/v/slow_tests/inout/thread_uninitialized_err.vv FAIL
------------------------------------------------------------------- difference: -----------------------------------------------------------------
--- /tmp/v/257500873191573/base 2025-01-07 11:54:50.125835442 +0000
+++ /tmp/v/257500873191573/target       2025-01-07 11:54:50.125835442 +0000
@@ -1,2 +1,2 @@
 ================ V panic ================
-V panic: unable to join thread
+0x7ff94e6d3404: at ???: RUNTIME ERROR: invalid memory access
-------------------------------------------------------------------------------------------------------------------------------------------------

@spytheman
spytheman force-pushed the cleanup_spawn_and_go branch from ff2ddf0 to 1764442 Compare January 15, 2025 10:08
@spytheman
spytheman force-pushed the cleanup_spawn_and_go branch from b4e121f to 21f8c64 Compare January 15, 2025 12:39
@spytheman spytheman changed the title cgen: cleanup spawn_and_go and fix #23390 cgen: fix cgen error for t.wait() on default 0 initialized thread value t (fix #23390) #23392 Jan 15, 2025
@spytheman spytheman changed the title cgen: fix cgen error for t.wait() on default 0 initialized thread value t (fix #23390) #23392 cgen: fix cgen error for t.wait() on default 0 initialized thread value t (fix #23390) Jan 15, 2025
@spytheman spytheman changed the title cgen: fix cgen error for t.wait() on default 0 initialized thread value t (fix #23390) cgen: fix cgen error for instance.t.wait() on default 0 initialized thread field t (fix #23390) Jan 15, 2025
@spytheman
spytheman merged commit 1281957 into vlang:master Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@spytheman spytheman spytheman approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cgen error when trying to thread.wait() on an unset thread field of struct

2 participants

@felipensp @spytheman