Repository navigation
crypto.ecdsa: migrate generate_key and makes it more simpler. - #23662
Merged
spytheman merged 3 commits intoFeb 9, 2025
Merged
Conversation
|
Connected to Huly®: V_0.6-22083 |
Contributor
Author
|
@felipensp , @spytheman : can you look to the jobs failed? Its run fine in my test box |
…nSSL < 3.0, where the CI runs)
…n warnings (reduce CI annotation noise, to make it easier to spot real problems)
Contributor
|
It should be fine now. I've commented out the |
spytheman
approved these changes
Feb 9, 2025
Contributor
Author
Thank..its my miss.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a 3rd PR sent in efforts to migrate
crypto.ecdsamodule to use high level api. In this current PR, its basically migrates two thing, ie, in the form:PrivateKey.public_key()to use the new one. Its approach was done by serializing this high level opaque (if availables) to der serialized bytes and get its back into other opaque and use this as public key part. If this high level opaque (evpkeyfield) was not availables, it will use the old one.generate_keyfunction to use this new approach , by just more simpler calling to the.new()and.public_key()..key_free().. Its has been replaced by its explicit counterparts of.free()of the desired key.Happy days