Skip to content

crypto.ecdsa: migrate generate_key and makes it more simpler. - #23662

Merged
spytheman merged 3 commits into
vlang:masterfrom
blackshirt:migrate-keypair-pubkey-and-genkey
Feb 9, 2025
Merged

spytheman merged 3 commits into
vlang:masterfrom
blackshirt:migrate-keypair-pubkey-and-genkey

Conversation

@blackshirt

@blackshirt blackshirt commented Feb 7, 2025 •

Copy link
Copy Markdown
Contributor

This is a 3rd PR sent in efforts to migrate crypto.ecdsa module to use high level api. In this current PR, its basically migrates two thing, ie, in the form:

  • Migrates PrivateKey.public_key() to use the new one. Its approach was done by serializing this high level opaque (if availables) to der serialized bytes and get its back into other opaque and use this as public key part. If this high level opaque (evpkey field) was not availables, it will use the old one.
  • Simplify generate_key function to use this new approach , by just more simpler calling to the .new() and .public_key() .
  • Removes .key_free() .. Its has been replaced by its explicit counterparts of .free() of the desired key.
  • Just some cleansup of bits

Happy days

@huly-for-github

Copy link
Copy Markdown

Connected to Huly®: V_0.6-22083

@blackshirt

Copy link
Copy Markdown
Contributor Author

@felipensp , @spytheman : can you look to the jobs failed? Its run fine in my test box

…n warnings (reduce CI annotation noise, to make it easier to spot real problems)
@spytheman

Copy link
Copy Markdown
Contributor

It should be fine now. I've commented out the openssl/core.h inclusion (that particular header is relatively new, see https://docs.openssl.org/3.4/man7/openssl-core.h/ ).

@spytheman
spytheman merged commit f3493e1 into vlang:master Feb 9, 2025
@blackshirt

Copy link
Copy Markdown
Contributor Author

It should be fine now. I've commented out the openssl/core.h inclusion (that particular header is relatively new, see https://docs.openssl.org/3.4/man7/openssl-core.h/ ).

Thank..its my miss..

@blackshirt
blackshirt deleted the migrate-keypair-pubkey-and-genkey branch February 10, 2025 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants