Skip to content

cgen: fix array fixed assignment for @[keep_args_alive] - #23805

Merged
spytheman merged 3 commits into
vlang:masterfrom
felipensp:fix_keep_alive_call_fixed_array
Feb 28, 2025
Merged

spytheman merged 3 commits into
vlang:masterfrom
felipensp:fix_keep_alive_call_fixed_array

Conversation

@felipensp

@felipensp felipensp commented Feb 25, 2025 •

Copy link
Copy Markdown
Member

Fix #23804 (partial fix)

With this patch the code builds on gcc and tcc without -cstrict. Because it does not cover the code generating ordering issue.

@huly-for-github

Copy link
Copy Markdown

Connected to Huly®: V_0.6-22215

@spytheman
spytheman marked this pull request as ready for review February 26, 2025 02:00
@spytheman

Copy link
Copy Markdown
Contributor

Please also add a test.

@felipensp

Copy link
Copy Markdown
Member Author

Please also add a test.

Added.

Comment thread vlib/v/tests/c_function/code.c

@spytheman spytheman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good work.

@spytheman
spytheman merged commit 80477e3 into vlang:master Feb 28, 2025
@felipensp
felipensp deleted the fix_keep_alive_call_fixed_array branch February 28, 2025 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

keep_args_alive error

2 participants