Repository navigation
crypto.ecdsa: improves internal sign_digest routine - #23960
Merged
Merged
Conversation
|
Connected to Huly®: V_0.6-22355 |
blackshirt
changed the title
sign_digest routine
blackshirt
changed the title
sign_digest routinesign_digest routine
blackshirt
changed the title
sign_digest routinesign_digest routine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves
sign_digestinternal routine used byPrivateKey.signmethod. Its done by eleminating one step ofC.EVP_PKEY_signcalls with null signature buffer to know the length (size) of required buffer. This maximal sizes of the buffer was already known by callingC.EVP_PKEY_size, so its not needed to callC.EVP_PKEY_signjust to know the size of required buffer and we can allocate the buffer instead and callC.EVP_PKEY_signdirectly with this allocated buffer.In my benchmark test, there are small improvements on this part
and after patch
Thanks