Skip to content

x.crypto.chacha20: enables supports for 64-bit counter - #24053

Merged
spytheman merged 4 commits into
vlang:masterfrom
blackshirt:64bit-counter-features
Mar 27, 2025
Merged

spytheman merged 4 commits into
vlang:masterfrom
blackshirt:64bit-counter-features

Conversation

@blackshirt

@blackshirt blackshirt commented Mar 26, 2025 •

Copy link
Copy Markdown
Contributor

This PR enables partial support for creating ChaCha20 cipher with 64-bit counter, see (#23904) issues about this features requested. I call its a partial support, because not all functionality was availables for 64-bit counter variant of ChaCha20 ciphers for current time of writing, especially for xor_key_stream, it still need to be looked again. The .encrypt method was tested working with this new variant of cipher. I am having difficulty finding trusted sources that can be used as references.

With this PR merged, its possible to create new variant of ChaCha20 stream cipher with 64-bit counter, by providing 8-bytes length of nonce into new_cipher routine.
The test has been added with samples of data generates from modified ptyhon script.

Updates:

I have add a test for xor_key_stream behaviour for ChaCha20 cipher with 64-bit counter
The golang script to produce verified output was included in the comments of the test files.

Thanks

@huly-for-github

Copy link
Copy Markdown

Connected to Huly®: V_0.6-22444

@blackshirt blackshirt changed the title x.crypto.chacha20: partially activated supports for 64-bit counter x.crypto.chacha20: enables partial supports for 64-bit counter Mar 26, 2025
@blackshirt blackshirt changed the title x.crypto.chacha20: enables partial supports for 64-bit counter x.crypto.chacha20: enables supports for 64-bit counter Mar 27, 2025
Comment thread vlib/x/crypto/chacha20/README.md Outdated
Comment thread vlib/x/crypto/chacha20/README.md Outdated
Comment thread vlib/x/crypto/chacha20/README.md Outdated
Comment thread vlib/x/crypto/chacha20/chacha.v Outdated
Comment thread vlib/x/crypto/chacha20/chacha_64bitctr_test.v Outdated
Comment thread vlib/x/crypto/chacha20/chacha_64bitctr_test.v Outdated
@spytheman
spytheman merged commit 19a6668 into vlang:master Mar 27, 2025
@blackshirt
blackshirt deleted the 64bit-counter-features branch March 27, 2025 20:18
@blackshirt

Copy link
Copy Markdown
Contributor Author

Thanks for merging it. There are several areas that can be improved later. I think its solid enough for now, i will left it as is, and continues my other work..
Good days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants