Repository navigation
cgen: fix codegen for assigning nil or 0 to option ptr field - #24502
Merged
Merged
Conversation
felipensp
changed the title
|
Connected to Huly®: V_0.6-22870 |
felipensp
changed the title
nil or 0 to option ptr field
felipensp
marked this pull request as ready for review
May 17, 2025 22:01
spytheman
reviewed
May 18, 2025
Contributor
There was a problem hiding this comment.
Please add assertions too.
spytheman
reviewed
May 18, 2025
| fn test_main() { | ||
| mut green_arena := Arena{} | ||
| arena_init(mut green_arena, 64 * 1024) | ||
| } |
Contributor
There was a problem hiding this comment.
Please assert that at least green_arena.data is not nil, and that green_arena.head is not nil .
spytheman
approved these changes
May 18, 2025
spytheman
left a comment
spytheman
left a comment
Contributor
There was a problem hiding this comment.
Excellent work, although the tests currently do not have assertions, they at least check that the generated C code compiles, unlike on master.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #24447
Fix #24500