Repository navigation
db.sqlite: fix get_text to trim data after (including) first 0 character - #25040
Merged
Merged
Conversation
|
Connected to Huly®: V_0.6-23557 |
spytheman
approved these changes
Aug 5, 2025
spytheman
left a comment
spytheman
left a comment
Contributor
There was a problem hiding this comment.
Excellent find. Thank you 🙇🏻♂️ .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using SQLite and selecting a text column, C.strlen is used to calculate the string's length. Due to C.strlen stopping at the first 0 character, data can get cut off. This PR modifies the get_text function to use C.sqlite3_column_bytes instead of C.strlen to calculate the strings length, preserving the entire data.